Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookoff - Fix Incorrect parent class in cookoff sounds #10083

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Cookoff - Fix Incorrect parent class in cookoff sounds #10083

merged 1 commit into from
Jun 21, 2024

Conversation

Cyruz143
Copy link
Contributor

When merged this pull request will:

  • Assumed typo, found this when testing alternate sounds and getting a UBC

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

jokoho48
jokoho48 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@jokoho48 jokoho48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very likely a typo.

@PabstMirror PabstMirror added this to the 3.18.0 milestone Jun 21, 2024
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Jun 21, 2024
@LinkIsGrim LinkIsGrim merged commit db6c4a7 into acemod:master Jun 21, 2024
5 checks passed
@Cyruz143 Cyruz143 deleted the fix_cookoff_snds branch June 24, 2024 16:11
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@Cyruz143 @blake8090
Cookoff - Fix incorrect parent class in cookoff sounds (acemod#10083)
3d6c2c7 
Fix incorrect parent

Co-authored-by: Cyruz143 <root.cyruz@gmail.com>
@Mike-MF Mike-MF changed the title Fix - Incorrect parent class in cookoff sounds Cookoff - Fix Incorrect parent class in cookoff sounds Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

@jokoho48 jokoho48 jokoho48 approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Cyruz143 @jokoho48 @PabstMirror @LinkIsGrim